search

ISISComputingGroup / lewis-ess

Let's write intricate simulators!
GNU General Public License v3.0
21 stars 19 forks source link

Any new improvements? #276

Closed chansdad closed 3 years ago

chansdad commented 4 years ago

This is one of the many useful projects i have seen in the age of IOT. anyone working on this actively? Would like to have some new features added to it . Most importantly adding support for device types. so presently , we have to create "A Device" that can be controlled on a single port , great if you have a single device and could be useful in a factory or plant setting . if it is a device type , we can have multiple devices and be able to control all the devices , essentially it will allow a large volume of devices and lift the limitation on the total number of devices that can be simulated on a host as # of ports are limited. Also plugins to auto create the device or device type files based on some markup language as opposed to writing python code .

Thanks

mattclarke commented 4 years ago

Hi. We are not doing much with lewis at the moment because it currently meets our requirements. However, some of your suggestions are interesting, so we will look into them next time we are working on the code base.

Thanks for getting in touch :)

chansdad commented 4 years ago

Thanks . Repurposed it for the time being , by writing the device objects into a array .. While in my case devices dont interact with one another , would be good to really utilize the state machine to set different conditions in the device . For now each of the objects state is updated by way of updating its properties. Further more one of the key things i noticed is state is not persisted across restarts which is significant .. Also telnet is a big no no to control device behavior .I warpped the commands in a rest api . Kind of hard coded for now , I am not an expert level python programmer , hacked my way and got it to do what i wanted , but this product sure has a TON of potential with the right set of features..

mattclarke commented 4 years ago

Can you create a draft PR, so we can see what you have done please? It might be something we could use/add

chansdad commented 4 years ago

This was on my plate for a while , I will start cleaning up a bit and will write up something .

chansdad commented 3 years ago

Unfortunately did not get time to create a draft PR . are you still enhancing this project?

mattclarke commented 3 years ago

Not so much, it currently has the functionality the main contributors generally need. But if we require new functionality then we will implement it.

Still happy to look at and discuss PRs from other people though :D