Closed John-Holt-Tessella closed 2 years ago
@DominicOram John's left now, right? Shall we close this?
He has, yes. I want to remind myself of what this was for before closing it. I'll add it to my list of things to look at.
I understand why you are reluctant to approve this, and I don't know what the original reason for this modification is, but I wanted to comment here as we've done exactly the same thing at our site for the following case:
str
, float
, int
etc and let lewis cast them as strings and encode them as usual.lamda x: x
so lewis doesn't try to convert it back to a string. I accept that might not be a good enough reason to approve the PR.
I've changed it so that Lewis is as forgiving as possible now and added a test. I don't think docs are required as they'll basically boil down to "specify it in any type you want". @mattclarke and @chris-d-gregory look ok to you?
👍
Yes, looks good.
We occasionally see an issue where we get a type error mixing bytes and string. Although we can not see where the error is coming from we don't want push to fall over so: