search

ISISComputingGroup / lewis-ess

Let's write intricate simulators!
GNU General Public License v3.0
21 stars 19 forks source link

Added some utilities written at ISIS #296

Closed DominicOram closed 3 years ago

DominicOram commented 3 years ago

This adds some utilities written at ISIS that could be helpful to the wider community.

I didn't think core.utils was a sensible place as they're more aimed at people who are actually building emulators.

DominicOram commented 3 years ago

Thanks @mattclarke, I'm fixing some of the flake8 errors now

mattclarke commented 3 years ago

This looks useful: thanks @DominicOram and gang!

DominicOram commented 3 years ago

This looks useful: thanks @DominicOram and gang!

Some of it's quite old, I suspect you may have written parts of it...

DominicOram commented 3 years ago

Think it's all done, happy for it to be merged whenever

mattclarke commented 3 years ago

Still seems to be some inconsistent docstring args.

DominicOram commented 3 years ago

Would be good to have this merged, you still looking at it @mattclarke or would you like me to take a look at the failing builds?

mattclarke commented 3 years ago

Still waiting for the docstrings args to be sorted out ;)

DominicOram commented 3 years ago

Sorry, missed that, look ok now?

mattclarke commented 3 years ago

Great, thank you. I'll just take a quick look to see what is up with the build then I'll merge it

mattclarke commented 3 years ago

I'll fix the tests in a separate PR as it has nothing to do with this PR