ISISComputingGroup / lewis-ess

Let's write intricate simulators!
GNU General Public License v3.0
21 stars 19 forks source link

StreamHandler shouldn't inherit from asynchat.async_chat #306

Open mattclarke opened 2 years ago

mattclarke commented 2 years ago

Makes testing a pain as need to be patched out. Better to wrap an instance of async_chat and call methods on that. An instance can probably be passed in through the constructor of StreamHandler and this means we can use a test double rather than using "patch".