ISISNeutronMuon / MDANSE

MDANSE: Molecular Dynamics Analysis for Neutron Scattering Experiments
https://www.isis.stfc.ac.uk/Pages/MDANSEproject.aspx
GNU General Public License v3.0
20 stars 5 forks source link

[ENHANCEMENT] Improved resolution input #343

Closed MBartkowiakSTFC closed 4 months ago

MBartkowiakSTFC commented 6 months ago

Is your feature request related to a problem? Please describe. At the moment the instrument resolution is defined by the user using peak function parameters specified in the internal units of MDANSE. This means that a Gaussian function will require the user to input a correct value of $\sigma$ in the units of radian/ps. Most users work with full width at half maximum (FWHM) of the peak, and most likely use meV as the energy unit.

Describe the solution you'd like Similar to other widgets, we can have the GUI use an understandable representation of peak width, and then convert it to native MDANSE input.

A specialised tab for instrument parameters would give us more space to visualise the peak, choose the correct unit, etc.

Describe alternatives you've considered A helper dialog would be another option, but in the long run we will need an instrument tab anyway.

Additional context Some users will not be neutron instrument users at all, so we should dedicate more space to the resolution settings to make it clearer to them which option to pick if they are not familiar with typical values of resolution of neutron instruments.