ISISNeutronMuon / MDANSE

MDANSE: Molecular Dynamics Analysis for Neutron Scattering Experiments
https://www.isis.stfc.ac.uk/Pages/MDANSEproject.aspx
GNU General Public License v3.0
20 stars 5 forks source link

[BUG] ASE converter fails to read the box size from extended XYZ files #344

Closed MBartkowiakSTFC closed 5 months ago

MBartkowiakSTFC commented 6 months ago

Description of the error We converted a trajectory in the extended XYZ format using the ASE converter. It was a system with a unit cell and periodic boundary conditions both defined in the trajectory file. However, the MDANSE trajectory after the conversion does not contain this information.

Describe the expected result The trajectory information should indicate that the system is periodic.

Describe the actual result The value for periodic boundary conditions was shown to be False.

Suggested fix

  1. Manual test of the ASE loader to verify that ASE correctly reads the unit cell information.
  2. Changes to the MDANSE code to make sure that the unit cell information is stored.

Additional details N/A