ISISNeutronMuon / MDANSE

MDANSE: Molecular Dynamics Analysis for Neutron Scattering Experiments
https://www.isis.stfc.ac.uk/Pages/MDANSEproject.aspx
GNU General Public License v3.0
20 stars 4 forks source link

[BUG] Eccentricity weight setting #378

Open ChiCheng45 opened 5 months ago

ChiCheng45 commented 5 months ago

The weight setting in the eccentricity job seems to replace the mass in the moment of inertia calculation with the weight setting value so that it might not be a moment of inertia anymore. It also means that the weighting procedure does not follow what is stated in the documentation. Additionally no weighting is applied to the radius of gyration calculation.

Suggested fix Remove the weight setting and change the moment of inertia so that it uses the atomic weight not the weight setting value.

Additional details Here is an example where I set the weight setting to charge. The moment of inertia is zero and additionally the units are wrong in the plot. image