ISISNeutronMuon / MDANSE

MDANSE: Molecular Dynamics Analysis for Neutron Scattering Experiments
https://www.isis.stfc.ac.uk/Pages/MDANSEproject.aspx
GNU General Public License v3.0
21 stars 5 forks source link

Remove qhull #398

Closed MBartkowiakSTFC closed 6 months ago

MBartkowiakSTFC commented 6 months ago

Description of work MDANSE has been relying on an old implementation of Qhull copied from scipy. This has now been replaced with the Qhull implemented in scipy.spatial, which gives us the advantage of using an up-to-date version of the code. Also, it reduces the level of uncertainty about the licensing of MDANSE, as the code base now contains less code copied from other projects, where the correct authorship contribution was becoming unclear.

Fixes

  1. Removed the qhull code from MDANSE/Extensions,
  2. Added the scipy.spatial import in Voronoi analysis.
  3. Removed the setup.py from MDANSE/Extensions, as it is not being used directly.

To test Run Voronoi analysis on a trajectory and check that it produces plottable results.