ISISNeutronMuon / MDANSE

MDANSE: Molecular Dynamics Analysis for Neutron Scattering Experiments
https://www.isis.stfc.ac.uk/Pages/MDANSEproject.aspx
GNU General Public License v3.0
18 stars 4 forks source link

[BUG] NeutronDynamicTotalStructureFactor: mismatch between default DISF and DCSF parameters #459

Closed MBartkowiakSTFC closed 2 weeks ago

MBartkowiakSTFC commented 3 weeks ago

Description of the error Normally, it was enough to calculate the Dynamic Coherent and Dynamic Incoherent Structure Factors (DCSF and DISF) with the default parameters to produce matching inputs for the NeutronDynamicTotalStructureFactor (NDTSF) calculation. Now, the correlation window settings for DISF make the normal output shorter (in time units) than the DCSF.

Describe the expected result The standard inputs of DCSF and DISF analyses should produce input files which work for the NDTSF analysis.

Describe the actual result At the moment, the two analysis types are handled differently, and the NDTSF run fails.

Suggested fix Could NDTSF analysis automatically select the right frames from the DCSF output? The analysis window effect on the DISF time axis could be accounted for by truncation of the DCSF results.

Additional details N/A