ISISNeutronMuon / MDANSE

MDANSE: Molecular Dynamics Analysis for Neutron Scattering Experiments
https://www.isis.stfc.ac.uk/Pages/MDANSEproject.aspx
GNU General Public License v3.0
18 stars 4 forks source link

Minimal multiprocessing improvement #471

Closed MBartkowiakSTFC closed 2 weeks ago

MBartkowiakSTFC commented 2 weeks ago

Description of work At the moment, multicore jobs work, but do not report progress correctly. This PR changes the way progress is reported for multicore jobs.

closes #447 closes #361

Note: this PR should let you pause and resume multicore jobs, but terminating multicore jobs has not been enabled by this PR.

Fixes Set OMP_NUM_THREADS to 1 in the GUI launcher, suppressing numpy multithreading. Removed threadpool from the list of running modes. Added a method to Status for directly updating the progress of multicore jobs. Removed the super().combine call from MeanSquareDisplacement.

To test Run a job using multiple cores. Check if the progress is updated correctly. Specifically, try running MeanSquareDisplacement anaylsis in single- and multicore modes. Progress should update correctly for both.