Closed ChiCheng45 closed 1 week ago
Looks good, definitely a step in the right direction.
Please check the following before we merge it:
Looks good, definitely a step in the right direction.
Please check the following before we merge it:
- In analysis.rst, line 231 there is a normalisation condition equation. What was it supposed to be? This dot over the 'equals' sign probably wasn't meant to be there.
- In correlation.rst the dot symbol appears in several equations. Is it supposed to be multiplication? If so, should we just remove it?
- in scattering.rst, line 170, there is a 'this consider' phrase which needs rewriting.
- Also in scattering.rst, there are 5 references in total to 'target_CN'. Which section do you think it was supposed to be?
- In scattering.rst, the equations 78 and 79 can't both be right. Most likely only one of them should have a tag 'isotropic system', but I am not sure if some other changes are needed for the anisotropic case. (Should there be a sum over n somewhere in eq. 79?)
- trajectory.rst: PDB may not need to be on the list (your own observation).
Description of work