ISO-TC211 / ISO19111

Revision of ISO19111 - Spatial referencing by coordinates.
2 stars 0 forks source link

DerivedCRS and its associations #11

Closed jetgeo closed 7 years ago

jetgeo commented 7 years ago

From @RogerLott:

For derived CRS we have agreed that · the derived CRS inherits the datum of its base CRS and we want the model to show this. · a derived CRS does not necessarily have to be of the same type as its base CRS. · the derivedCRS type depends upon its CS. Put another way, the constraints on CS-CRS associations apply to derivedCRSs. So for example a derivedEngineeringCRS has the same constraint in being associated to an EngineeringCS as does an EngineeringCRS.

We forced the datum inheritance through the constraints in DerivedCRS {count(baseCRS.datum)=1 implies datum=baseCRS.datum} and {count(baseCRS.ensemble)=1 implies ensemble=baseCRS.ensemble} (in combination with the constraint {count(datum + ensemble)=1} in the SingleCRS class). I think we need to continue to force datum inheritance through these constraints.

The second of the above bullets is new. Because we had previously had a derivedCRS having an association to a conversion and conversion was defined as a coordinate operation without change of datum, we had assumed that a derivedCRS had to be the same type as its base CRS type. This was reflected in the DerivedCRS diagram. But now it is to be allowed for example for an engineering CRS to inherit a geodetic datum. I think this new thinking invalidates the derivedCRS diagram. So if the derivedCRS diagram is to be replaced, how do we show in the UML that the derivedCRS subtypes associations to CS are constrained? Do we need a version of the CS-CRS associations diagram but showing each of the derived*CRS subclasses associated to the appropriate CS class?

jetgeo commented 7 years ago

Ok, think I have done this now:

New figures in https://github.com/ISO-TC211/ISO19111/tree/master/Figures/Main%20version

jetgeo commented 7 years ago

From @RogerLott:

jetgeo commented 7 years ago

OK, done. I have no strong feelings about subtyping for DerivedGeographicCRS, my thinking was just that it should be the same structure as for the main CRS. I guess it will work either way. https://github.com/ISO-TC211/ISO19111/tree/master/Figures/Main%20version

jetgeo commented 7 years ago

From @RogerLott (2017-05-17): Derived CRS. We were not sure that we are there yet with this part of the model. We again discussed grids derived from map grids, i.e. CRSs derived from projected CRSs. As projected CRS is itself a derivedCRS, this is a double derivation! We think it would be useful if the model showed that a CRS may be derived from a projectedCRS. In the last iteration we made some changes to the model to show derived CRS classes subtyped off DerivedCRS which was subtyped off SingleCRS. This allows continuous iteration but we are not happy with its generality – a derived[type]CRS can only have a [type]CRS as its base because of the datum inheritance issue.

jetgeo commented 7 years ago

OK, I have reverted back to a previous version with multiple inheritance for DerivedCRSs. I don't think I have done any other changes after that version, so it should be OK. I added the subclass for ProjectedCRS, but I think it is better to name it "DerivedProjectedCRS". This is in line with the structure for the other DerivedCRSs, and the name "derivedFromProjectedCRS" is more of a operation name, not a class name. The confusion should not be more then it allready is in this diagram :). Question: What shall be the baseCRS of a DerivedProjectedCRS? I suppose it shall be ProjectedCRS? As it is now, it is inherited from ProjectedCRS, which means it is a GeodeticCRS. Should there be a baseCRS association from DerivedCRS to ProjectedCRS? New diagrams in https://github.com/ISO-TC211/ISO19111/tree/master/Figures/Main%20version

RogerLott commented 7 years ago

Derived CRSs

See attached 'rules' for derived CRSs.

Derived CRSs 2017-05-18.docx

RogerLott commented 7 years ago

Derived CRSs 2017-05-18v2.docx

Sorry, a bit missing from the previous upload, corrected here with missing text in blue.

RogerLott commented 7 years ago

Are the 'rules' for derived CRSs met through the existing diagrams but with this addition: g2 cs crs associations_rl

jetgeo commented 7 years ago

New diagram: cs crs associations