search

ISSOtm / fortISSimO

A speed-and size-focused Game Boy music driver, drop-in replacement for hUGEDriver ~ Try the demo!
http://eldred.fr/fortISSimO/
Other
20 stars 3 forks source link

Muting a channel does not disable stereo effects for that channel #25

Open DevEd2 opened 1 month ago

ISSOtm commented 1 month ago

This gets funky. To allow the channel to be resumed when the muting ends, this state needs to be persisted—so we can't write directly to NR51. This means that the user will have to manually commit that intermediate variable to NR51 themselves, combining any (e.g.) SFX bits themselves.

That's arguably one more layer of complication, and it's not what hUGEDriver does either. So I think it should be opt-in.

What do you think?

DevEd2 commented 1 month ago

I can't speak for everyone, but as someone who's working on a sound effect driver I feel like the option to change the stereo behavior in regards to muting would definitely be appreciated. A toggle would be the best option IMO, that way people working on e.g. a demo don't have to deal with any additional overhead caused by the required tweaks.

ISSOtm commented 1 month ago

Then I'll work on that!