Reorganize thread declarations

ISSUIUC / TARS-Software

Illinois Space Society's flight software codebase for the TARS avionics system

https://issuiuc.github.io/flightcode-docs/classes.html

17 stars 4 forks source link

Reorganize thread declarations #23

Closed AyberkY closed 2 years ago

AyberkY commented 2 years ago

Here's a summary of what's in this PR:

Moved all THD_FUNCTION() thread declarations to main.cpp
Created "tick functions" for the sensors, which are called by the threads in main.cpp. This allows us to abstract the internals of the thread to sensor.h/.cpp and other libraries in the lib/ directory
Created a class called rocketFSM to encapsulate the finite state machine logic
renamed rocket.h/.cpp to rocketFSM.h/.cpp
renamed servo.h/.cpp to servoControl.h/.cpp

AyberkY commented 2 years ago

[AV-24] Re-organize thread declaration to remove any #include"*.cpp" statements from the flight software

AyberkY commented 2 years ago

we have some hardcoded values for things like sleep time, thread priority, and thread size that we might want to group together as variables in a separate file, or just at the top now that they're more spaced out

Definitely agree with this. Could you make a Code ticket for it on the AV Trello?

The only other thing I can think of that we would possibly want to do is separate the sensors.

I don't think I follow, but if it improves readability then I'm all for it.