Feature/av 112 encapsulate servo control class

ISSUIUC / TARS-Software

Illinois Space Society's flight software codebase for the TARS avionics system

https://issuiuc.github.io/flightcode-docs/classes.html

17 stars 4 forks source link

Feature/av 112 encapsulate servo control class #25

Closed colinpk2 closed 2 years ago

colinpk2 commented 2 years ago

fixed implementation of the framework for the servo control class. pointer paths have been reduced from term papers to single pointers as private variables, in the servo control class.

AyberkY commented 2 years ago

lol

AyberkY commented 2 years ago

Fixed the "compiler issue" you guys were having. You were misspelling PWM as PMW lol.

Made some fixes and everything compiles now. Also move ServoControl.h/.cpp into its own directory under lib/

Please add the following + get another review so we can merge this:

Add header docstrings giving a brief description along with a list of authors
- Check out the silsim source code for examples
- pls do this for both the .h and .cpp files. thank

gautamdayal commented 2 years ago

lgtm!