search

ISSUIUC / TARS-Software

Illinois Space Society's flight software codebase for the TARS avionics system
https://issuiuc.github.io/flightcode-docs/classes.html
17 stars 4 forks source link

Combining FifoBuffer and HistoryBuffer #67

Closed redindelible closed 1 year ago

redindelible commented 1 year ago

The major difference between FifoBuffer and HistoryBuffer right now is that FifoBuffer has a destructive pop method, which removes items from its buffer, while HistoryBuffer can only be filled and thus may be used to look at recent history. However, using the new FifoView API available in the removed-pointer-struct branch, FifoBuffer will no longer have pop, making it's functionality a superset of HistoryBuffer, obviating the need for the latter.

We should write the code to calculate derivatives for FifoBuffer, which will let us remove HistoryBuffer and simplify the code base.

redindelible commented 1 year ago

It's been implemented in removed-pointer-struct

gautamdayal commented 1 year ago

Don't close the issue if it hasn't been thoroughly tested @redindelible

sendhil2 commented 1 year ago

How about now, now that this change is in removed-pointer-struct?

gautamdayal commented 1 year ago

Yup closing the issue since it's been implemented in another branch that is currently in review