search

ISSUIUC / TARS-Software

Illinois Space Society's flight software codebase for the TARS avionics system
https://issuiuc.github.io/flightcode-docs/classes.html
21 stars 4 forks source link

Removed pointer struct #72

Closed sendhil2 closed 1 year ago

sendhil2 commented 1 year ago

This branch has changes that removed the "pointer_struct" that was everywhere. It also uses the sensor data structures that were implemented but not used. Additionally, FifoBuffer was further improved and replaced HistoryBuffer.

sendhil2 commented 1 year ago

Biggest issue we (and by we I mean Gautam) have identified so far is that telemetry is reading its data from a structure that never gets updated. The fix is making it use a DataLogBuffer view instead of that struct. Should be simple enough

gautamdayal commented 1 year ago

Also run clang-format whenever this PR is approved, I don't like Actions screaming at me

sendhil2 commented 1 year ago

I think I've addressed all the concerns that have been brought up thus far.

gautamdayal commented 1 year ago

@sendhil2 Run clang format on the branch (make sure the line limit is like 120 instead of 80)

sendhil2 commented 1 year ago

clang format has been run

sendhil2 commented 1 year ago

Why do we have Platformio build CI? It's not set up properly.

gautamdayal commented 1 year ago

Why do we have Platformio build CI? It's not set up properly.

bypassing, it's outdated. will change later