search

ISU-Monarchs / HabitatRestoration

R data package containing data from a series of habitat restoration projects running from 2016-2019
0 stars 0 forks source link

Add zero counts for bee (and possibly other data) #1

Closed jarad closed 4 years ago

jarad commented 7 years ago

Many of the bee data have zero counts. We need to make sure that these show up in a future data set.

jarad commented 5 years ago

We could include this as part of either a vignette or as examples in the helpfiles for each data type. Actually I'm thinking maybe we want this as a vignette.

nulloa commented 5 years ago

I've created a vignette for the bee data. Let me know if you are looking for anything more specific.

nulloa commented 5 years ago

Also in order to build the vignettes when you download the files you need to run this command:

devtools::install(build_vignettes = TRUE)
jarad commented 5 years ago

If a survey had no bee information at all, would those surveys get zeros? I feel like the current code will only fill zeros for surveys that had at least 1 observation. I think we need to complete using the survey data.frame.

nulloa commented 5 years ago

Ok this should be good now.

jarad commented 5 years ago

The zeros probably need to be added earlier, i.e. when the R data.frame is built. If this is not done, then users of the R package will probably use the data.frames incorrectly. But, this becomes a chicken-and-egg situation where we need the survey data.frame in order to construct other data.frames, e.g. the bee data.frame.

jarad commented 5 years ago

Rather than using the survey data.frame, use the existence of a file to indicate that a survey was done.

jarad commented 4 years ago

This was fixed for bee in commit 91916f24f19b. It should be fixed for other data in the process of addressing #96.