search

ISibboI / evalexpr

A powerful expression evaluation crate 🦀.
GNU Affero General Public License v3.0
325 stars 54 forks source link

Should EvalExprError implement Clone? #121

Closed benwr closed 1 year ago

benwr commented 1 year ago

This is an awesome project! It's making my life a lot easier.

I'm building a tool for which it would be very useful to be able to clone an EvalExprError. Right now I'm getting around it by just converting to a string early, but passing around the errors would be much nicer. Is there a reason it doesn't implement Clone?

benwr commented 1 year ago

Whoops - looks like somebody beat me to it and submitted #116 . nvm!

ISibboI commented 1 year ago

Are you using the latest version, or is this pull request unreleased? I can make a new release if you need it.

On Wed, 12 Apr 2023, 6.55 Ben Weinstein-Raun, @.***> wrote:

Closed #121 https://github.com/ISibboI/evalexpr/issues/121 as completed.

— Reply to this email directly, view it on GitHub https://github.com/ISibboI/evalexpr/issues/121#event-8980604289, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASATXULS24KDCO2AEZJ6WDXAYRSBANCNFSM6AAAAAAWPHPUIE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

benwr commented 1 year ago

I think the Clone instance isn't yet in the released version (8.1.0)

ISibboI commented 1 year ago

I now relased 8.2.0 containing the change, thank you for notifying!

benwr commented 1 year ago

Awesome, thanks!