search

IT-Academy-BCN / ita-challenges-frontend

Frontend of ITA Challenges Project
MIT License
3 stars 7 forks source link

Refactoring: Date Formatter isn't a service, is a pipe #396

Open jonatanvicente opened 3 months ago

jonatanvicente commented 3 months ago

There is a service called date-formatter.service. Nevertheless, actions implemented on that are most appropriately on a pipe element. In addition, there is a pipe called format-date.pipe (not implemented). Masks implemented should be located at this pipe.

Yul1b3th commented 3 months ago

Al final no he utilizado el servicio date-formatter.service.ts ¿lo podemos eleminar?

Tampoco he utilizado format-date.pipe.ts ¿lo podemos eliminar?

el DatePipe tiene este sintaxis {{ fecha | date: formato: timezone: locale }}

y he implemenatdo esto en el html date:'mediumDate':'':currentLang