IT-Academy-BCN / ita-landing-backend

5 stars 1 forks source link

Create user in database with registration form (#42) #49

Closed Lauddar closed 1 year ago

Lauddar commented 1 year ago

The registration function has been implemented with the required fields following the schema at https://github.com/IT-Academy-BCN/ita-wiki/blob/main/back/src/schemas/dniSchema.ts. Therefore, the ADMIN role is assigned by default, but user role management has not been considered yet. Also, a validator for DNI and NIF has been implemented to ensure its validity.

Issue #42.

CloudSalander commented 1 year ago

Okey, Laura. I'm going to merge this branch. It's doing what it has to do.
Really good jobs with authentications, specially generating specifical rules for dni/nie.

I only found a non critical failure with seeders. With an empty database migrated, couldn not run the seeder cause, apparently, it's not including not-null value(dni).

Thank you!