CloudSalander
commented
11 months ago Hi, Cynthia! Good job. Some comments:
- The feature is about getting collaborators from Github,not only CallingGithubApi, refering to the name of the CallingGithubApi.
- Please, don't leave comments of old code. If we need to recover old code we simply look to previous versions/commits.
- We need some refactor on the CollaboratorsController. We have repeated logic 5 times with the collaborators methods. Can we use some parameter to avoid this repeatition?
- Need to solve some new conflicts.
Need some time to still checking the feature, but If you can check this firsts issues. Thanks!
In this branch, I have implemented the API call to GitHub for the various repositories of the project using the owner's token. The main component responsible for handling this functionality is the CollaboratorsController, which contains the necessary logic. The retrieved data is filtered to include only the collaborator's name, photo, and GitHub URL.
The implementation adheres to Swagger documentation standards, providing clear guidelines for API consumption. To ensure a streamlined and organized approach, a single URL is used to access the required information.
The implemented functionality has been thoroughly tested, and all tests are passing successfully. This ensures the reliability and functionality of the API endpoints.
---UPDATE---
I have made some modifications to the code regarding collaborators. Now, a single API call will return all the collaborators without any duplicates, as we had several collaborators appearing in more than two projects.
In order to reflect these changes, I have updated the Swagger documentation accordingly. Now, it accurately represents the updated behavior of the API.
Additionally, I have tested the modifications, and I can confirm that all the tests are functioning as expected after the changes were made.