IT-Academy-BCN / ita-profiles-frontend

2 stars 0 forks source link

28-FE-feature-add-home-responsive #30

Closed treee97 closed 8 months ago

treee97 commented 8 months ago

Updated Changes

Previous Changes

This PR focuses on adding responsive behaviour.

Because the user details and filters will be displayed in two different formats, one as a modal for smaller screens and the other as a normal component for bigger screens, I decided to divide both components in 3 pieces:

The main component is the one being displayed in bigger screens. Inside the content component can be found. The modal component is the one displayed in smaller screens. The content component is also here. The content component is where the data is placed.

This PR also fixed some scroll errors

Feedback

image image image

ghost commented 8 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/IT-Academy-BCN/ita-profiles-frontend/30/63957d67/abd440cef2cfc2e76b8a3eceae09973dc96fe912.svg)](https://app.codesee.io/r/reviews?pr=30&src=https%3A%2F%2Fgithub.com%2FIT-Academy-BCN%2Fita-profiles-frontend) #### Legend CodeSee Map legend
sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud