Media service skeleton

[LG1401]

Description

Create a basic skeleton service for the media service.

Acceptance Criteria

• [x] Basic service repository set up
• [x] Basic api endpoint for the service, which provides basic media information as per the domain model

[myluki2000]

Description of changes

I have now completed the basic implementation skeleton of the media service. There is no linked pull request because the repo was newly created and all work was pushed directly to the master branch. All further changes after this issue is marked as done should be handled using pull requests.

The media service now includes a running setup of the service which provides a graphql endpoint as described in the schema file. Some slight modifications from the schema file provided as a "master schema" of the system have been made. Some of these have already been discussed with other team members and the schemas will be harmonized soon.

How has this been tested?

Please describe the test strategy you followed.

• [ ] automated unit test
• [ ] automated integration test
• [ ] automated acceptance test
• [ ] manual, exploratory test

In case of manual test, please document the test well including a set of user instructions and prerequisites. Each including an action, it's result, and where appropriate a screenshot.

Checklist before requesting a review

• [x] My code follows the coding guidelines of this project
• [x] I have performed a self-review of my code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] My code fulfilles all acceptance criteria
• [ ] I have added tests that prove my fix is effective or that my feature works
  • Postponed until we have a solid testing strategy for our graphql endpoints
• [ ] New and existing unit tests pass locally with my changes
  • Not applicable
• [ ] I have made corresponding changes to the documentation
  • Proper wiki documentation for service and endpoint is postponed until service design has stabilized. For now, look at the graphql schema files to see how the service can be used
• [ ] I have added explanation of architectural decision and rationales to wiki/adr
  • Not applicable
• [ ] I have updated the changes in the ticket description
  • Not applicable

Checklist for reviewer

• [x] The code works and does not throw errors
• [x] The code is easy to understand and there are no confusing parts
• [ ] The code follows the coding guidelines of this project
• [x] The code change accomplishes what it is supposed to do
• [x] I cannot think of any use case in which the code does not behave as intended
• [x] The added and existing tests reasonably cover the code change
• [x] I cannot think of any test cases, input or edge cases that should be tested in addition
• [x] Description of the change is included in the documentation

[myluki2000]

@ZombieAlienRobot can you review this please? (or someone else)

[ZombieAlienRobot]

One thing I would change, is to rename the mediaRecords(Line 31) and mediaRecordsById(Line 36) in the MediaController to getMediaRecords and getMediaRecordsById, for better clarity. In fact it is required that methods should start with a verb, acording to the coding guideline l. Other than that everything is fine @myluki2000

[myluki2000]

One thing I would change, is to rename the mediaRecords(Line 31) and mediaRecordsById(Line 36) in the MediaController to getMediaRecords and getMediaRecordsById

Shouldn't they have the same name as the names of the graphql queries?

[ZombieAlienRobot]

Yeah, you're right. Then it's fine and this issue can be closed. @LG1401