Closed retifrav closed 3 years ago
These commands were based on an earlier version of Scipy, I suppose. So in case, somebody uses the older version they might end up having issues.
This was the old location in Scipy. Since Scipy 1.6.0 has been out for less than a month, and using cumulative_trapezoid
is not backwards compatible, I still use cumtrapz
but updated the location in 169729242cd83244994c4a29767a4b64b2159e2b.
I was trying to use Helita in a Jupyter notebook, and import statement have failed with the following error:
I've checked the SciPy documentation, and
quadrature
is not a module but a function, and to fix that the following change is required in sources:I can create a pull-request, if you want.
By the way,
quadrature
doesn't seem to be used at all, so this line might even be deleted. Also, thecumtrapz
function seems to be renamed tocumulative_trapezoid
in latest versions if SciPy.I've also put here another issue with Jupyter notebooks from RH15D repository, but then I realized that it will be better to post it there.