search

ITA-Solar / helita

A Python library for solar physics from the Institute of Theoretical Astrophysics, University of Oslo
BSD 3-Clause "New" or "Revised" License
9 stars 17 forks source link

Several changes related to Bifrost and Ebysus #7

Closed jumasy closed 6 years ago

jumasy commented 6 years ago

Bifrost.py: Includes get_time, slices cuts bifrost_uvotrd.py: includes optically thin radiative code bifrost_topology.py: includes topology code ebysus.py: many changes atom_tools: tools related to atoms, atoms files, source functions etc.

jumasy commented 6 years ago

Oh! Now I found the comment.

We didn’t do any pull request now. Is this the one that we did during my last visit in Oslo? I’ll remove _build from git. How would be the best? Going backwards in time or just removing? The latter will be much much easier.

About the bq_t5. This is a (I guess you know) tool that uses helita and matplotlib libraries, so it is in Bifrost code instead. Carmel did the documentation and I though that this could be connected to helita. Do you really want this one out? How I could have a different documentation in my working directory and the git? This will be a hassle right? Another option will be to have the bq_t5 documentation in Bifrost code instead. Comments.

We can do some effort on merging the files in Gottingen if you llike it.

tiagopereira commented 6 years ago

Closing to avoid propagation of tainted history from jumasy:master.