ITA-Solar / solo-spice-ql

Quicklook software for Solar Orbiter SPICE
MIT License
7 stars 1 forks source link

Bug - binned images not processed correctly #32

Closed martinwiesmann closed 3 years ago

martinwiesmann commented 3 years ago

I ran into the following error when trying to use spice_raster_browser.pro with the file

solo_L2_spice-n-ras-db-int_20200602T125545_V10_12583761-000.fits

% XMANAGER: Caught unexpected error from client application. Message follows... % Array subscript for WD must have same size as source expression. % Execution halted at: SPICE_BROWSER_UPDATE_IMAGE 113 /Users/wtthomps/ssw/so/spice/idl/quicklook/quicklook/spice_raster_browser/spice_browser_update_image.pro % SPICE_BROWSER_BASE_EVENT 259 /Users/wtthomps/ssw/so/spice/idl/quicklook/quicklook/spice_raster_browser/spice_browser_base_event.pro % XMANAGER_EVLOOP_STANDARD 478 /Applications/exelis/idl/lib/xmanager.pro % XMANAGER 710 /Applications/exelis/idl/lib/xmanager.pro % SPICE_BROWSER_WIDGET 993 /Users/wtthomps/ssw/so/spice/idl/quicklook/quicklook/spice_raster_browser/spice_browser_widget.pro % SPICE_RASTER_BROWSER 161 /Users/wtthomps/ssw/so/spice/idl/quicklook/quicklook/spice_raster_browser/spice_raster_browser.pro % $MAIN$

The error occurs when I try to change between wavelength windows. I believe the error occurs when I try to select a window which has been compressed along the wavelength dimension, or one of the dumbbells.

martinwiesmann commented 3 years ago

Here’s another file that I’m having problems with.

solo_L1_spice-n-ras_20211025T081723_V01_83886248-000.fits

This time, the problem shows up immediately after calling spice_raster_browser.pro after just one window is displayed.

% Array subscript for WD must have same size as source expression. % Execution halted at: SPICE_BROWSER_UPDATE_IMAGE 113 /Users/wtthomps/ssw/so/spice/idl/quicklook/quicklook/spice_raster_browser/ spice_browser_update_image.pro % SPICE_BROWSER_WIDGET 977 /Users/wtthomps/ssw/so/spice/idl/quicklook/quicklook/spice_raster_browser/ spice_browser_widget.pro % SPICE_RASTER_BROWSER 161 /Users/wtthomps/ssw/so/spice/idl/quicklook/quicklook/spice_raster_browser/ spice_raster_browser.pro % $MAIN$

I also noticed that there’s no Level 2 version of this file, nor of the one just before it.

Bill

martinwiesmann commented 3 years ago

Fixed the problem with this pull request #33

The problem was not the binning itself, but the fact that the lambda dimension collapsed into one pixel. Another issue was that different windows may have different heights.