ITA-Solar / solo-spice-ql

Quicklook software for Solar Orbiter SPICE
MIT License
7 stars 1 forks source link

Compacts code for level 3 file generation #40

Closed martinwiesmann closed 2 years ago

martinwiesmann commented 2 years ago

In this merge, I merged the SPICE_DATA method xcfit_block into the create_l3 method to avoid duplication of code. I also added a few new keywords to create_l3 and xcfit_block:

If both 'no_fitting' and 'no_widget' are set, then some of the data cubes are not being set (i.e. result, residual, include, const). So I have to make sure, that those are initialised, so that the FItS file can be saved.

Also updated, the wiki and the README.

tfredvik commented 2 years ago

approximated_slit should not be set as default. Not yet, anyway. If it turns out that the code for determining the slit height doesn't work that well and I'm not able to get it to work reliably, the we should consider setting approximated_slit as default.