UPSTART 04: Database and Repositories - Githubissues

ITC-NTHU / LyricLab

1 stars 0 forks source link

UPSTART 04: Database and Repositories #5

Open jerry914 opened 3 weeks ago

jerry914 commented 3 weeks ago

Tasks Overview

1. Environment Setup: ✅
2. Database Migrations: ✳️ Please draw the entities as concepts and their database tables in an entity-relationship diagram and place in README.md
3. ORM Setup: ✅
4. Repository Pattern: ✅
5. Project Structure: ✅

RobuCop/Code Smell Offenses

Reek Warnings:
- app.rb:
- UncommunicativeVariableName: LyricLab::App - Variable e is uncommunicative
- lrclib_api.rb:
- UtilityFunction: Lrclib::Api#lyric_data - Doesn't depend on instance state