search

ITC-NTHU / LyricLab

1 stars 0 forks source link

DEVELOP 06: Application Layer Refactoring #9

Open jerry914 opened 6 days ago

jerry914 commented 6 days ago

Great progress for this week. You implemented all the functions listed.

But as your project grows, please also check the code quality test(Rubocop and Reek):

  1. Block has too many lines - app/application/controllers/app.rb
  2. Method has too many lines - app/application/services/load_song_history.rb
  3. Perceived complexity is too high - app/infrastructure/chatgpt/gpt_word_processor.rb
  4. Module has too many lines - spec/helpers/vcr_helper.rb
  5. Duplicate method calls - Multiple files
  6. Feature Envy - Multiple files
  7. Too many statements - Multiple files
  8. Uncommunicative variable names - Multiple files
  9. Missing space after '#' in comments - Multiple files
  10. Trailing whitespace detected - Multiple files
  11. Indentation issues - Multiple files