search

ITDP / the-online-brt-planning-guide

Online collaborative version of the BRT Planning Guide
https://brtguide.itdp.org
Other
6 stars 20 forks source link

Refuse non-LFS binary assets: halt Robrt or add a different check #35

Closed jonasmalacofilho closed 8 years ago

jonasmalacofilho commented 8 years ago

I just merged #13 and only after noticed there were binary assets (jpgs) in there that were not using LFS. This causes immediate issues (users will start getting "there are modified files" after any checkout) and also long term problems, since it increases the size of the repository and what needs to be cloned.

Other pull requests have the same issue, and it's useful to have a tool warn us when we need to deal with these files. From that, we can instruct the user to install LFS before adding assets and perform the merge without polluting the history.

jonasmalacofilho commented 8 years ago

Fixed in b692f7079d4a12eeba6caf28401e60720c5e3745

jonasmalacofilho commented 8 years ago

The tool currently doesn't check the entire pull request (only commits since it's been configured). Reopening...

jonasmalacofilho commented 8 years ago

Actually, TRAVIS_COMMIT_RANGE includes the entire pull request... Lucky us! : )

jonasmalacofilho commented 8 years ago

3a6e0bb was made in error...

Commit has since been amended and force pushed.