search

ITDP / the-online-brt-planning-guide

Online collaborative version of the BRT Planning Guide
https://brtguide.itdp.org
Other
6 stars 20 forks source link

Update 00-project-initiation.src #9

Closed aegauthier closed 7 years ago

aegauthier commented 8 years ago

i hate that clause

jonasmalacofilho commented 8 years ago

can I merge this?

aegauthier commented 8 years ago

I don't know :(

I am back from China, but am pretty discombobulated. When I get back to the office next week will look at this

On Tue, Sep 20, 2016 at 8:44 PM, Jonas Malaco notifications@github.com wrote:

can I merge this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/protocubo/the-online-brt-planning-guide/pull/9#issuecomment-248478618, or mute the thread https://github.com/notifications/unsubscribe-auth/AP1IFqXpTep8Sz1ZgzZJyucOo_JwVLnlks5qsH3lgaJpZM4JscAQ .

​Aimee Gauthier | Chief Program Officer Institute for Transportation & Development Policy 9 East 19th Street, 7th Floor, New York, NY 10003 Office +1 212 629 8001 www.itdp.org | @ITDP_HQ | facebook.com/ITDP.org

Promoting sustainable and equitable transportation worldwide

aszasz commented 8 years ago

I think this does not need to be merged (in fact, I believe this can be closed and deleted), it was about an experience with pull requests during a trainign session... The comment is only Aimée (British dry) sense of humour when I told her that as a pull requester she should "provide an explanation about why she wanted to make the change". Still, on behalf of the experience, let Aimée see this... and reply.

When time comes that Aimée will be the responsible for maintaining the guide, she will remember this and will be more understanding with contributors explanations : )

jonasmalacofilho commented 8 years ago

@aegauthier, you've been given privilege to merge or (most likely) close this pull request.

Add a comment, hit the "close and comment" button and enjoy ; )

jonasmalacofilho commented 7 years ago

@aegauthier I'm closing this (which means, not merging/accepting this)...

Just so you know, you should have the access rights to do it too; on open pull requests you should see a "Close" button right bellow the text area to write a comment.

jonasmalacofilho commented 7 years ago

Err... I think I remember asking you @aegauthier about this in one of our calls, and that this was just a test; but if it wasn't, let me know and I'll reopen and merge this instead.

aegauthier commented 7 years ago

this is fine by me : )

On Wed, Dec 28, 2016 at 3:37 PM, Jonas Malaco notifications@github.com wrote:

Err... I think I remember asking you @aegauthier https://github.com/aegauthier about this in one of our calls, and that this was just a test; but if it wasn't, let me know and I'll reopen and merge this instead.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/protocubo/the-online-brt-planning-guide/pull/9#issuecomment-269537074, or mute the thread https://github.com/notifications/unsubscribe-auth/AP1IFvluTWtS3u2UjCm276cfdAKBrEMLks5rMsiRgaJpZM4JscAQ .

-- ​Aimee Gauthier | Chief Program Officer Institute for Transportation & Development Policy 9 East 19th Street, 7th Floor, New York, NY 10003 Office +1 212 629 8001 www.itdp.org | @ITDP_HQ | facebook.com/ITDP.org

Promoting sustainable and equitable transportation worldwide