search

ITHACA-FV / ITHACA-FV

Reduced order modelling techniques for OpenFOAM
https://ithaca-fv.github.io/ITHACA-FV/
GNU Lesser General Public License v3.0
169 stars 96 forks source link

OpenFOAM: Invitation to the data-community submodule #564

Open Kutalmis-Bercin opened 3 months ago

Kutalmis-Bercin commented 3 months ago

Hello @giovastabile - It has been a very very long time.

At the time this ticket was opened, we did not have a framework that easily allowed for community contributions to be integrated into OpenFOAM. However, this has recently changed.

In the latest version, we have introduced a framework for incorporating data science-related contributions, which can be found here: https://gitlab.com/openfoam/community/sig-data-modelling/data-community

Could you let us know if you would be interested in hooking ITHACA-FV into this new submodule?

Many thanks for your understanding.

Kind regards, Kuti

giovastabile commented 3 months ago

Dear Kuti,

I am happy to hear news from you. Yes, I think it would be a good opportunity to hook ITHACA-FV into the submodule. Let me know which steps are needed.

Cheers,

Giovanni

From: Kutalmis-Bercin @.> Sent: Wednesday, July 3, 2024 1:07 PM To: ITHACA-FV/ITHACA-FV @.> Cc: Giovanni Stabile @.>; Mention @.> Subject: [ITHACA-FV/ITHACA-FV] OpenFOAM: Invitation to the data-community submodule (Issue #564)

Hello @giovastabilehttps://github.com/giovastabile - It has been a very very long time.

At the time this ticket was opened, we did not have a framework that easily allowed for community contributions to be integrated into OpenFOAM. However, this has recently changed.

In the latest version, we have introduced a framework for incorporating data science-related contributions, which can be found here: https://gitlab.com/openfoam/community/sig-data-modelling/data-community

Could you let us know if you would be interested in hooking ITHACA-FV into this new submodule?

Many thanks for your understanding.

Kind regards, Kuti

— Reply to this email directly, view it on GitHubhttps://github.com/ITHACA-FV/ITHACA-FV/issues/564, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGAFEQ4RX3EK4HRBMJEIMTZKPLO7AVCNFSM6AAAAABKJKZOIGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM4DQMZUHAZDKOI. You are receiving this because you were mentioned.Message ID: @.***>

Kutalmis-Bercin commented 2 months ago

Dear Giovanni,

Many thanks for your reply.

(I believe) The requirements are very loose: https://gitlab.com/openfoam/community/sig-data-modelling/data-community#two-tier-system:

  1. Include a README.md file as a user guide.
  2. Up-to-date contact details of the maintainer.
  3. Error-free compilation with the latest OpenFOAM® version (Gcc 7.5.0 and Clang 15.0).
  4. Minimum one reproducible tutorial.

Also, we may need to introduce a mini Allwmake script (e.g. https://github.com/Weishuo93/NN_Pred/blob/master/Allwmake and a tag per release.

We can work on all of the above together.

If these sound you well, I can initiate the process by opening a merge request in our repository. Please note that we are going to introduce only a hook into a submodule repository; therefore, no changes in GitHub repository is expected (except the All* scripts and tags).

Please let me know if anything is unclear or needs further elaboration.

Many thanks again for your willingness to share your contributions.

Kind regards, Kuti

giovastabile commented 2 months ago

Dear Kuti,

I believe we should already match all the requirements. The only one which I need to check is the compilation with clang (usually is more strict than gcc). Next week, I will do a test and correct any issues that may arise. In the meantime, you can open the merge request.

what do you think?

Regards,

Giovanni

From: Kutalmis-Bercin @.> Sent: Friday, July 12, 2024 10:46 AM To: ITHACA-FV/ITHACA-FV @.> Cc: Giovanni Stabile @.>; Mention @.> Subject: Re: [ITHACA-FV/ITHACA-FV] OpenFOAM: Invitation to the data-community submodule (Issue #564)

Dear Giovanni,

Many thanks for your reply.

(I believe) The requirements are very loose: https://gitlab.com/openfoam/community/sig-data-modelling/data-community#two-tier-system:

  1. Include a README.md file as a user guide.
  2. Up-to-date contact details of the maintainer.
  3. Error-free compilation with the latest OpenFOAM® version (Gcc 7.5.0 and Clang 15.0).
  4. Minimum one reproducible tutorial.

Also, we may need to introduce a mini Allwmake script (e.g. https://github.com/Weishuo93/NN_Pred/blob/master/Allwmake and a tag per release.

We can work on all of the above together.

If these sound you well, I can initiate the process by opening a merge request in our repository. Please note that we are going to introduce only a hook into a submodule repository; therefore, no changes in GitHub repository is expected (except the All* scripts and tags).

Please let me know if anything is unclear or needs further elaboration.

Many thanks again for your willingness to share your contributions.

Kind regards, Kuti

— Reply to this email directly, view it on GitHubhttps://github.com/ITHACA-FV/ITHACA-FV/issues/564#issuecomment-2225111599, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGAFEWIZBXLCYHT7BWDSDTZL6JV3AVCNFSM6AAAAABKJKZOIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRVGEYTCNJZHE. You are receiving this because you were mentioned.Message ID: @.***>

Kutalmis-Bercin commented 2 months ago

Dear Giovanni,

That sounds good to me. I may not be available until next week, but once I am, I will test the hook and open the merge request.

Many thanks again.

Kind regards, Kuti