search

ITISFoundation / cookiecutter-osparc-service

A cookiecutter for integrating services in oSparc simcore platform
MIT License
0 stars 5 forks source link

new service integration library #115

Open JavierGOrdonnez opened 1 month ago

JavierGOrdonnez commented 1 month ago

see issue

Moved to ci-service-integration-library. Rework of .osparc, Makefile, and file structure was needed.

Seems to work well; dummy project created with it is able to run "make build" without errors.

JavierGOrdonnez commented 3 weeks ago

Dear @pcrespov , sorry for the lack of context. This is the main PR, which addresses the change of tooling regarding service integration (see issue ). The other one (make "make build" is secondary and work-in-progress).

Regarding the elimination of bin/*, I did so imitating the structured of the more up-to-date cookiecutter of Jupyterlab services, which already uses ci-service-integration-library instead of the old service-integration. @GitHK insisted that we should perform that change - please add your comments.

pcrespov commented 3 weeks ago

Dear @pcrespov , sorry for the lack of context. This is the main PR, which addresses the change of tooling regarding service integration (see issue ). The other one (make "make build" is secondary and work-in-progress).

Regarding the elimination of bin/*, I did so imitating the structured of the more up-to-date cookiecutter of Jupyterlab services, which already uses ci-service-integration-library instead of the old service-integration. @GitHK insisted that we should perform that change - please add your comments.

Yes, I think here we need to align since there is some misunderstanding

JavierGOrdonnez commented 3 weeks ago

Hi Pedro, I agree. Let's discuss with @GitHK also. I am busy with other tasks at the moment and this isnt urgent, thus I propose we discuss about this in a few days. Best, Javier.