Cleanup simcore stack docker-compose's network and environment configs

[pcrespov]

Review docker-compose configurations for simcore stack.

Specifically, I have noticed in https://github.com/ITISFoundation/osparc-ops-environments/blob/main/services/simcore/docker-compose.yml

• environment section:
  • env vars already defined in osparc-simcore config e.g. https://github.com/ITISFoundation/osparc-ops-environments/blob/main/services/simcore/docker-compose.yml#L183
  • Debug env vars that might be active in production: https://github.com/ITISFoundation/osparc-ops-environments/blob/main/services/simcore/docker-compose.yml#L211-L220
• network section: I assume only networks defined in ops should be added at this stage
  • default, ... are networks that should be defined only in osparc-simcore config: https://github.com/ITISFoundation/osparc-ops-environments/blob/main/services/simcore/docker-compose.yml#L263 or https://github.com/ITISFoundation/osparc-ops-environments/blob/main/services/simcore/docker-compose.yml#L293-L295
  • why this internal service is public? https://github.com/ITISFoundation/osparc-ops-environments/blob/main/services/simcore/docker-compose.yml#L461

[pcrespov]

I discussed these with @YuryHrytsuk . I let you follow up as you consider best. thx

[YuryHrytsuk]

I discussed these with @YuryHrytsuk . I let you follow up as you consider best. thx

Thanks @pcrespov, I will follow up

[sanderegg]

so @pcrespov @YuryHrytsuk and me already discussed the "default" network. This is actually something wrongly defined in osparc-simcore docker-compose. And this guy has to be defined there. naming it default was a bit of a bad idea I think since this is confusing. We should rename it to internal or something similar.