pre-commit hook `validate-maintenance-page-html` does not capture missing maintenance pages

ITISFoundation / osparc-ops-environments

osparc operations

MIT License

3 stars 6 forks source link

pre-commit hook `validate-maintenance-page-html` does not capture missing maintenance pages #806

Closed YuryHrytsuk closed 1 week ago

YuryHrytsuk commented 2 months ago

We introduced new domains (deployment_fqdns) to AWS Master which broke deploy_maintenance_page CI task. The pre-commit hook shall capture this

### Wishes for Deployment CI Tests
- [X] easy to run same tests locally
- [X] easy to add new tests
- [X] flexibility in tools for tests (e.g. python or bash script)

Done :heavy_check_mark: in https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/1093

mrnicegyu11 commented 2 months ago

The pre-commit hook should be moved to a CI stage test