Rationale
This hook relies on .config.location and on manually generated repo.config in osparc-config repository. This pre-commit hook will fail for any new user trying to commit to the osparc-ops-environments since these users are unaware of the dependency on repo.config from osparc-config repository. Moreover, any non-ITIS user cannot even get this repository (hence commit at all) since it is not publicly available.
UPD:
The idea of pre-commit hook relying on physical generated files from other repositories seems to be wrong. This is why in our GitHub CI we cannot run pre-commit as is (we have to skip stack-yaml-generated-is-valid hook)
What do these changes do?
Remove
stack-yaml-generated-is-validpre-commit hookRationale This hook relies on
.config.locationand on manually generatedrepo.configinosparc-configrepository. This pre-commit hook will fail for any new user trying to commit to theosparc-ops-environmentssince these users are unaware of the dependency onrepo.configfromosparc-configrepository. Moreover, any non-ITIS user cannot even get this repository (hence commit at all) since it is not publicly available.UPD: The idea of pre-commit hook relying on physical generated files from other repositories seems to be wrong. This is why in our GitHub CI we cannot run
pre-commitas is (we have to skipstack-yaml-generated-is-validhook)Related issue/s
Related PR/s
Checklist