search

ITISFoundation / osparc-simcore-clients

python client for osparc-simcore public API
https://itisfoundation.github.io/osparc-simcore-clients/
MIT License
0 stars 5 forks source link

fixing e2e tests #185

Closed pcrespov closed 2 months ago

pcrespov commented 2 months ago

What do these changes do?

IMO this is a good example of a faulty design: using make recipes in the unit testing code. makefile are close to the user and used as a tool that collect CLI options for the upper-most level user. I would argue, base on POLA , that makefile can call pytest but not the other way around

Related issue/s

How to test

For internal developers

sanderegg commented 2 months ago

well I would argue that it depends what you are testing. if testing the Makefile targets then it can be a good idea. but that is already an integration test.