ITISFoundation / osparc-simcore-clients

python client for osparc-simcore public API
https://itisfoundation.github.io/osparc-simcore-clients/
MIT License
0 stars 5 forks source link

Pydantic v1 does not specify optional/nullable values correctly in openapi specs #203

Closed bisgaard-itis closed 1 week ago

bisgaard-itis commented 1 week ago

In the E2E tests we have detected, that osparc python package 0.8.* contains a bug. Namely, the endpoint GET /v0/credits/price might return a body in which usdPerCredit is null, but the client doesn't allow for this. This will be fixed by upgrading to pydantic v2, which will happen in osparc version >=0.9.0. Hence, I will only run the failing test with that version of the client in order to not pollute our e2e tests.