Closed pcrespov closed 1 year ago
common.Makefile has multiple recipes addressing code formatting and analysis that have overlapping functionality, namely:
make autoformat
isort
black
make codestyle
codestyle-ci
scripts/codestyle.bash
pylint
mypy
ci
make code-analysis
scripts/code-climate
codeclimate
make mypy
scripts/mypy.bash
See issue #2811 because we do not have in place a static-analysis in CI
@pcrespov you are working on this now right?
@sanderegg yes I will associate this case to my PR. thx
Implemented in SEE https://github.com/ITISFoundation/osparc-simcore/blob/master/scripts/common.Makefile#L112-L135
common.Makefile has multiple recipes addressing code formatting and analysis that have overlapping functionality, namely:
make autoformat
: runsisort
andblack
make codestyle
/codestyle-ci
:scripts/codestyle.bash
isort
,black
,pylint
andmypy
ci
(should not call make from CI!)make code-analysis
:scripts/code-climate
codeclimate
make mypy
scripts/mypy.bash
mypy
See issue #2811 because we do not have in place a static-analysis in CI