ITISFoundation / osparc-simcore

🐼 osparc-simcore simulation framework
https://osparc.io
MIT License
46 stars 27 forks source link

Add line-seperation character for better multiline logs handling using logspout #2782

Closed mrnicegyu11 closed 1 year ago

mrnicegyu11 commented 2 years ago

As stated by @sanderegg , it is apparently fairly easily for us to add an "end-of--current-log" separation-character to aid the grouping of multiline logs.

From the ops-side, we use a go regex to match the first line for a multiline-log using logspout. Once the regex is matched again, a new log-entry is started. All lines in between are considered as one multiline-log, starting with the first line, i.e. the one that matched the regex. (More info on this can be found in the logspout docker readme, we use MULTILINE_MATCH=first )

Currently we match ^(ERROR|WARNING|INFO|DEBUG|CRITICAL)[:]. This fails when terminal-colors are logged, an PR fixing this is pending here.

Actionable tasks:

Thanks, let's discuss and see if we can do it.

pcrespov commented 2 years ago

Please @mrnicegyu11 check as well

sanderegg commented 1 year ago

note that logspout was phazed out. we use docker dual logging now and the logs go straight to Graylog

matusdrobuliak66 commented 1 year ago

as mentioned before we do not use logspout anymore, and other mentioned things are already discussed here https://github.com/ITISFoundation/osparc-simcore/issues/4079