Outputs/inputs in 2 ports are not correctly deleted when nodes are disconnected

elisabettai commented 1 year ago

Long story short

There seem to be still some (small) issue with ports synchronization in dynamic services. This seems more on the inputs side, than on the outputs one

Expected behaviour

If a connection between 2 nodes is removed, the inputs shouldn't be there anymore in the second node.

Actual behaviour

Only some of the inputs are removed.

Steps to reproduce

Create a new JupyterLab Math (X)
In X, write one file in output_1 and one in output_2
Connect X to another service, e.g. Jupyter Smash (Y), this should result in the file in output_1 appearing in Y, input_1 and the file in output_2 appearing in Y, input_2
In the workbench, remove the connection between X and Y
In Y, I found that input_1 is not there anymore (as expected), while input_2 is still there (it should be removed as well)

Your environment

I shared a study on master where I observed the above https://osparc-master.speag.com/#/study/d9f1b6bc-7714-11ed-b944-02420a2d068b

More information

When I remove the connection, in the logger I see this:

It is weird that input_3 is mentioned, it shouldn't be there. I also checked the logs in the dy-sidecar of the node 34948e20-2b6c-486c-94c3-3b464ff3295e (Read_number), but I didn't see any useful information

GitHK commented 1 year ago

apparently https://github.com/ITISFoundation/osparc-simcore/pull/3476 did not fix it

GitHK commented 1 month ago

@elisabettai can you tell me if this is still the case?

ITISFoundation / osparc-simcore