ITISFoundation / osparc-simcore

🐼 osparc-simcore simulation framework
https://osparc.io
MIT License
43 stars 27 forks source link

re-opening a study that is being closed #4346

Open pcrespov opened 1 year ago

pcrespov commented 1 year ago

Currently closing a project takes some time because:

The closing procedure could be delayed ("soft-close") such that the user could reopen fast (~1mins). This is a typical behaviour of GC. We could

PROS

### Sundae
- [ ] https://github.com/ITISFoundation/osparc-simcore/issues/4399
- [ ] disable projects close when going to dashboard @odeimaiz
- [ ] ensure logout triggers close @pcrespov
- [ ] add API to delay-close projects without switching off services
### Watermelon
- [x] https://github.com/ITISFoundation/osparc-simcore/pull/4349
GitHK commented 1 year ago

Possible issue

Locking can get messy

When the project is used there is a lock that blocks (for example the opening of the project by others) When "existing" the project and before letting the GC close it, the project cannot be considered as unlocked. Otherwise another user can open it and we might end up in unexpected territory.

We want locking to still work as it does not, only the user has the ability to open it before the real closing is done.

Closing Tabs

This needs to work when the tab is closed (meaning delay close cannot be sent by the frontend). The close will simply not be sent (or can we avoid this)?


Side effects for current proposal:

@pcrespov some of my inputs here