ITISFoundation / osparc-simcore

🐼 osparc-simcore simulation framework
https://osparc.io
MIT License
44 stars 26 forks source link

🐛? Frontend: Remove ``sourceMappingURL``s #5801

Closed odeimaiz closed 2 months ago

odeimaiz commented 2 months ago

What do these changes do?

4 third party libraries (js files) we use in osparc include a path to their minified map file, which we don't host/include. These files are supposed to help debugging issues that might happen in those 3rd party libraries, but they are not required.

It could be that the some browsers we start in the e2e try to load the referenced map files and since we don't serve them, they fail the loading, leaving osparc in a funny state.

This PR removes the references to the sourceMappingURLs and luckily make the e2e happier? It should definitely remove the errors seen in: image

Related issue/s

How to test

Dev-ops checklist

odeimaiz commented 2 months ago

Let's see. 🤞🏻🤞🏻🤞🏻

Just curious: what triggers the displaying of the study/service UI in the frontend after the open call?

Do you mean this? https://github.com/ITISFoundation/osparc-simcore/blob/master/services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js#L176

odeimaiz commented 2 months ago

@elisabettai I added a console.error that might show the error thrown in the openStudy routine...

elisabettai commented 2 months ago

Let's see. 🤞🏻🤞🏻🤞🏻 Just curious: what triggers the displaying of the study/service UI in the frontend after the open call?

Do you mean this? https://github.com/ITISFoundation/osparc-simcore/blob/master/services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js#L176

Yeah, I guess. Looking at the playwright screenshots, the last thing we see before things go wrong it the "Creating Study" screen (for s4l-lite-master)

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud