ITISFoundation / osparc-simcore

🐼 osparc-simcore simulation framework
https://osparc.io
MIT License
44 stars 26 forks source link

πŸ› Block when acquiring redis lock #5804

Closed bisgaard-itis closed 2 months ago

bisgaard-itis commented 2 months ago

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.6%. Comparing base (cafbf96) to head (d427ea4). Report is 193 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5804/graphs/tree.svg?width=650&height=150&src=pr&token=h1rOE8q7ic&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5804?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) ```diff @@ Coverage Diff @@ ## master #5804 +/- ## ========================================= - Coverage 84.5% 81.6% -3.0% ========================================= Files 10 558 +548 Lines 214 28119 +27905 Branches 25 205 +180 ========================================= + Hits 181 22961 +22780 - Misses 23 5106 +5083 - Partials 10 52 +42 ``` | [Flag](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5804/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Ξ” | | |---|---|---| | [integrationtests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5804/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `65.1% <100.0%> (?)` | | | [unittests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5804/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `86.8% <100.0%> (+2.2%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5804?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Ξ” | | |---|---|---| | [...ver/src/simcore\_service\_webserver/projects/lock.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5804?src=pr&el=tree&filepath=services%2Fweb%2Fserver%2Fsrc%2Fsimcore_service_webserver%2Fprojects%2Flock.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvd2ViL3NlcnZlci9zcmMvc2ltY29yZV9zZXJ2aWNlX3dlYnNlcnZlci9wcm9qZWN0cy9sb2NrLnB5) | `95.8% <100.0%> (ΓΈ)` | | | [.../server/src/simcore\_service\_webserver/users/api.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5804?src=pr&el=tree&filepath=services%2Fweb%2Fserver%2Fsrc%2Fsimcore_service_webserver%2Fusers%2Fapi.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvd2ViL3NlcnZlci9zcmMvc2ltY29yZV9zZXJ2aWNlX3dlYnNlcnZlci91c2Vycy9hcGkucHk=) | `96.0% <100.0%> (ΓΈ)` | | ... and [566 files with indirect coverage changes](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5804/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)
bisgaard-itis commented 2 months ago

Closing this PR since I can see here that I encountered these issues because I did not publish my project as a template before creating the jobs. Doing so doesn't lock the project. @sanderegg

sanderegg commented 2 months ago

Closing this PR since I can see here that I encountered these issues because I did not publish my project as a template before creating the jobs. Doing so doesn't lock the project. @sanderegg

@bisgaard-itis not sure you haven't discovered a new bug instead... we can actually edit templates, so not sure if that is good or bad.

bisgaard-itis commented 2 months ago

Closing this PR since I can see here that I encountered these issues because I did not publish my project as a template before creating the jobs. Doing so doesn't lock the project. @sanderegg

@bisgaard-itis not sure you haven't discovered a new bug instead... we can actually edit templates, so not sure if that is good or bad.

Hmm πŸ’©, ok. But I guess it is not an immediate issue for the metamodeling. So I might simply try to create a ticket for this. Or what do you think @sanderegg? Would you consider it urgent to look into this? My approach would be to try to create a "read-only" lock so that several cloned can be created at the same time, but the template cannot be edited during this time.