search

ITISFoundation / osparc-simcore

🐼 osparc-simcore simulation framework
https://osparc.io
MIT License
44 stars 26 forks source link

πŸ›Fix ```up-devel``` Makefile target #5806

Closed sanderegg closed 2 months ago

sanderegg commented 2 months ago

What do these changes do?

PR https://github.com/ITISFoundation/osparc-simcore/pull/5776 prevented make up-devel to be functional. This fixes that. The gunicorn is expecting a DEBUG env variable that is an integer and does not go well with booleans.

Also the log level in devel mode is set back to DEBUG level.

Related issue/s

How to test

Dev-ops checklist

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.3%. Comparing base (cafbf96) to head (f394f1c). Report is 195 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5806/graphs/tree.svg?width=650&height=150&src=pr&token=h1rOE8q7ic&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5806?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) ```diff @@ Coverage Diff @@ ## master #5806 +/- ## ========================================= - Coverage 84.5% 77.3% -7.3% ========================================= Files 10 949 +939 Lines 214 39218 +39004 Branches 25 678 +653 ========================================= + Hits 181 30346 +30165 - Misses 23 8736 +8713 - Partials 10 136 +126 ``` | [Flag](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5806/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Ξ” | | |---|---|---| | [unittests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5806/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `77.3% <ΓΈ> (-7.3%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#carryforward-flags-in-the-pull-request-comment) to find out more. [see 929 files with indirect coverage changes](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5806/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)