ITISFoundation / osparc-simcore

🐼 osparc-simcore simulation framework
https://osparc.io
MIT License
44 stars 26 forks source link

🚑️Rclone: downgrade to 1.63.1 #5830

Closed sanderegg closed 1 month ago

sanderegg commented 1 month ago

What do these changes do?

After the tests done in https://github.com/ITISFoundation/osparc-simcore/discussions/5828 it is pretty visible that the new version of RClone, beside having a very bad bug that makes EC2 instances kernel panic that the current parameters make the download very slow, very bad.

Therefore this PR aims at downgrading the RClone back to 1.63.1 version, which seemed to be more stable even though still much slower (2x) than using official AWS tools. But at least it seems more or less bugfree.

Related issue/s

How to test

Dev-ops checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.5%. Comparing base (cafbf96) to head (20bdf5f). Report is 203 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5830/graphs/tree.svg?width=650&height=150&src=pr&token=h1rOE8q7ic&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5830?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) ```diff @@ Coverage Diff @@ ## master #5830 +/- ## ========================================= - Coverage 84.5% 81.5% -3.1% ========================================= Files 10 966 +956 Lines 214 43426 +43212 Branches 25 205 +180 ========================================= + Hits 181 35395 +35214 - Misses 23 7989 +7966 - Partials 10 42 +32 ``` | [Flag](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5830/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [integrationtests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5830/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `58.4% <ø> (?)` | | | [unittests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5830/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `80.6% <ø> (-4.0%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5830?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [...e-sdk/src/simcore\_sdk/node\_ports\_common/r\_clone.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5830?src=pr&el=tree&filepath=packages%2Fsimcore-sdk%2Fsrc%2Fsimcore_sdk%2Fnode_ports_common%2Fr_clone.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvc2ltY29yZS1zZGsvc3JjL3NpbWNvcmVfc2RrL25vZGVfcG9ydHNfY29tbW9uL3JfY2xvbmUucHk=) | `74.2% <ø> (ø)` | | | [...mcore\_service\_agent/modules/volumes\_cleanup/\_s3.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5830?src=pr&el=tree&filepath=services%2Fagent%2Fsrc%2Fsimcore_service_agent%2Fmodules%2Fvolumes_cleanup%2F_s3.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvYWdlbnQvc3JjL3NpbWNvcmVfc2VydmljZV9hZ2VudC9tb2R1bGVzL3ZvbHVtZXNfY2xlYW51cC9fczMucHk=) | `98.3% <ø> (ø)` | | ... and [970 files with indirect coverage changes](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5830/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)
sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud