🎨 Check for zero credits (if pricing unit cost is greater than 0)

matusdrobuliak66 commented 1 month ago

What do these changes do?

🎨 Check for zero credits (if pricing unit cost is greater than 0)

Related issue/s

relates https://github.com/ITISFoundation/osparc-issues/issues/1437
closes https://github.com/ITISFoundation/osparc-issues/issues/1438

Dev-ops checklist
- [ ] No ENV changes or I properly updated ENV (read the instruction)

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 70.73171% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 85.5%. Comparing base (cafbf96) to head (c300bb4). Report is 211 commits behind head on master.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=h1rOE8q7ic&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) ```diff @@ Coverage Diff @@ ## master #5835 +/- ## ========================================= + Coverage 84.5% 85.5% +0.9% ========================================= Files 10 880 +870 Lines 214 39321 +39107 Branches 25 565 +540 ========================================= + Hits 181 33624 +33443 - Misses 23 5582 +5559 - Partials 10 115 +105 ``` | [Flag](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [integrationtests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `52.5% <57.5%> (?)` | | | [unittests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `86.7% <53.3%> (+2.1%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [...kages/models-library/src/models\_library/wallets.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835?src=pr&el=tree&filepath=packages%2Fmodels-library%2Fsrc%2Fmodels_library%2Fwallets.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvbW9kZWxzLWxpYnJhcnkvc3JjL21vZGVsc19saWJyYXJ5L3dhbGxldHMucHk=) | `100.0% <100.0%> (ø)` | | | [...-v2/src/simcore\_service\_director\_v2/core/errors.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835?src=pr&el=tree&filepath=services%2Fdirector-v2%2Fsrc%2Fsimcore_service_director_v2%2Fcore%2Ferrors.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZGlyZWN0b3ItdjIvc3JjL3NpbWNvcmVfc2VydmljZV9kaXJlY3Rvcl92Mi9jb3JlL2Vycm9ycy5weQ==) | `72.3% <100.0%> (ø)` | | | [.../src/simcore\_service\_director\_v2/models/pricing.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835?src=pr&el=tree&filepath=services%2Fdirector-v2%2Fsrc%2Fsimcore_service_director_v2%2Fmodels%2Fpricing.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZGlyZWN0b3ItdjIvc3JjL3NpbWNvcmVfc2VydmljZV9kaXJlY3Rvcl92Mi9tb2RlbHMvcHJpY2luZy5weQ==) | `100.0% <100.0%> (ø)` | | | [...tor\_v2/modules/db/repositories/comp\_tasks/\_core.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835?src=pr&el=tree&filepath=services%2Fdirector-v2%2Fsrc%2Fsimcore_service_director_v2%2Fmodules%2Fdb%2Frepositories%2Fcomp_tasks%2F_core.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZGlyZWN0b3ItdjIvc3JjL3NpbWNvcmVfc2VydmljZV9kaXJlY3Rvcl92Mi9tb2R1bGVzL2RiL3JlcG9zaXRvcmllcy9jb21wX3Rhc2tzL19jb3JlLnB5) | `87.0% <100.0%> (ø)` | | | [...ore\_service\_director\_v2/api/routes/computations.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835?src=pr&el=tree&filepath=services%2Fdirector-v2%2Fsrc%2Fsimcore_service_director_v2%2Fapi%2Froutes%2Fcomputations.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZGlyZWN0b3ItdjIvc3JjL3NpbWNvcmVfc2VydmljZV9kaXJlY3Rvcl92Mi9hcGkvcm91dGVzL2NvbXB1dGF0aW9ucy5weQ==) | `81.4% <50.0%> (ø)` | | | [...imcore\_service\_webserver/director\_v2/\_api\_utils.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835?src=pr&el=tree&filepath=services%2Fweb%2Fserver%2Fsrc%2Fsimcore_service_webserver%2Fdirector_v2%2F_api_utils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvd2ViL3NlcnZlci9zcmMvc2ltY29yZV9zZXJ2aWNlX3dlYnNlcnZlci9kaXJlY3Rvcl92Mi9fYXBpX3V0aWxzLnB5) | `60.0% <50.0%> (ø)` | | | [...core\_service\_webserver/projects/\_nodes\_handlers.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835?src=pr&el=tree&filepath=services%2Fweb%2Fserver%2Fsrc%2Fsimcore_service_webserver%2Fprojects%2F_nodes_handlers.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvd2ViL3NlcnZlci9zcmMvc2ltY29yZV9zZXJ2aWNlX3dlYnNlcnZlci9wcm9qZWN0cy9fbm9kZXNfaGFuZGxlcnMucHk=) | `91.3% <83.3%> (ø)` | | | [...or\_v2/modules/db/repositories/comp\_tasks/\_utils.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835?src=pr&el=tree&filepath=services%2Fdirector-v2%2Fsrc%2Fsimcore_service_director_v2%2Fmodules%2Fdb%2Frepositories%2Fcomp_tasks%2F_utils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZGlyZWN0b3ItdjIvc3JjL3NpbWNvcmVfc2VydmljZV9kaXJlY3Rvcl92Mi9tb2R1bGVzL2RiL3JlcG9zaXRvcmllcy9jb21wX3Rhc2tzL191dGlscy5weQ==) | `70.7% <60.0%> (ø)` | | | [...simcore\_service\_webserver/projects/projects\_api.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835?src=pr&el=tree&filepath=services%2Fweb%2Fserver%2Fsrc%2Fsimcore_service_webserver%2Fprojects%2Fprojects_api.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvd2ViL3NlcnZlci9zcmMvc2ltY29yZV9zZXJ2aWNlX3dlYnNlcnZlci9wcm9qZWN0cy9wcm9qZWN0c19hcGkucHk=) | `84.2% <16.6%> (ø)` | | ... and [876 files with indirect coverage changes](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5835/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)