🐛 fix for pending transactions

matusdrobuliak66 commented 1 month ago

What do these changes do?

🐛 In the previous PR, I introduced an option to run the pricing unit with a cost of 0 credits. This PR fixes an issue with the if statement that would evaluate bool(Decimal(0)) as False, which is not intended.

Related issue/s

How to test

services/resource-usage-tracker/tests/unit/with_dbs/test_process_rabbitmq_message_with_billing_cost_0.py

Dev-ops checklist

[ ] No ENV changes or I properly updated ENV (read the instruction)

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.0%. Comparing base (cafbf96) to head (aff537f). Report is 219 commits behind head on master.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5852/graphs/tree.svg?width=650&height=150&src=pr&token=h1rOE8q7ic&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5852?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) ```diff @@ Coverage Diff @@ ## master #5852 +/- ## ========================================= - Coverage 84.5% 65.0% -19.6% ========================================= Files 10 593 +583 Lines 214 29515 +29301 Branches 25 205 +180 ========================================= + Hits 181 19189 +19008 - Misses 23 10274 +10251 - Partials 10 52 +42 ``` | [Flag](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5852/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [integrationtests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5852/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `64.0% <ø> (?)` | | | [unittests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5852/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `87.0% <100.0%> (+2.4%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5852?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [...\_usage\_tracker/resource\_tracker\_background\_task.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5852?src=pr&el=tree&filepath=services%2Fresource-usage-tracker%2Fsrc%2Fsimcore_service_resource_usage_tracker%2Fresource_tracker_background_task.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvcmVzb3VyY2UtdXNhZ2UtdHJhY2tlci9zcmMvc2ltY29yZV9zZXJ2aWNlX3Jlc291cmNlX3VzYWdlX3RyYWNrZXIvcmVzb3VyY2VfdHJhY2tlcl9iYWNrZ3JvdW5kX3Rhc2sucHk=) | `95.0% <100.0%> (ø)` | | | [...usage\_tracker/resource\_tracker\_process\_messages.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5852?src=pr&el=tree&filepath=services%2Fresource-usage-tracker%2Fsrc%2Fsimcore_service_resource_usage_tracker%2Fresource_tracker_process_messages.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvcmVzb3VyY2UtdXNhZ2UtdHJhY2tlci9zcmMvc2ltY29yZV9zZXJ2aWNlX3Jlc291cmNlX3VzYWdlX3RyYWNrZXIvcmVzb3VyY2VfdHJhY2tlcl9wcm9jZXNzX21lc3NhZ2VzLnB5) | `81.2% <100.0%> (ø)` | | ... and [601 files with indirect coverage changes](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5852/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)