ITISFoundation / osparc-simcore

🐼 osparc-simcore simulation framework
https://osparc.io
MIT License
44 stars 26 forks source link

⬆️Remove redis deprecation warning #5869

Closed sanderegg closed 1 month ago

sanderegg commented 1 month ago

What do these changes do?

/home/runner/work/osparc-simcore/osparc-simcore/.venv/lib/python3.10/site-packages/servicelib/redis.py:81: DeprecationWarning: Call to deprecated close. (Use aclose() instead) -- Deprecated since version 5.0.1.
    await self._client.close(close_connection_pool=True)

Related issue/s

How to test

Dev-ops checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 87.7%. Comparing base (cafbf96) to head (10b5795). Report is 222 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869/graphs/tree.svg?width=650&height=150&src=pr&token=h1rOE8q7ic&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) ```diff @@ Coverage Diff @@ ## master #5869 +/- ## ========================================= + Coverage 84.5% 87.7% +3.1% ========================================= Files 10 1367 +1357 Lines 214 56828 +56614 Branches 25 1284 +1259 ========================================= + Hits 181 49858 +49677 - Misses 23 6696 +6673 - Partials 10 274 +264 ``` | [Flag](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [integrationtests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `65.1% <33.3%> (?)` | | | [unittests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `85.7% <68.4%> (+1.1%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [...ibrary/src/servicelib/aiohttp/application\_setup.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869?src=pr&el=tree&filepath=packages%2Fservice-library%2Fsrc%2Fservicelib%2Faiohttp%2Fapplication_setup.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvc2VydmljZS1saWJyYXJ5L3NyYy9zZXJ2aWNlbGliL2Fpb2h0dHAvYXBwbGljYXRpb25fc2V0dXAucHk=) | `77.6% <100.0%> (ø)` | | | [...c/servicelib/fastapi/long\_running\_tasks/\_routes.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869?src=pr&el=tree&filepath=packages%2Fservice-library%2Fsrc%2Fservicelib%2Ffastapi%2Flong_running_tasks%2F_routes.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvc2VydmljZS1saWJyYXJ5L3NyYy9zZXJ2aWNlbGliL2Zhc3RhcGkvbG9uZ19ydW5uaW5nX3Rhc2tzL19yb3V0ZXMucHk=) | `88.5% <100.0%> (ø)` | | | [.../service-library/src/servicelib/functools\_utils.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869?src=pr&el=tree&filepath=packages%2Fservice-library%2Fsrc%2Fservicelib%2Ffunctools_utils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvc2VydmljZS1saWJyYXJ5L3NyYy9zZXJ2aWNlbGliL2Z1bmN0b29sc191dGlscy5weQ==) | `100.0% <100.0%> (ø)` | | | [packages/service-library/src/servicelib/redis.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869?src=pr&el=tree&filepath=packages%2Fservice-library%2Fsrc%2Fservicelib%2Fredis.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvc2VydmljZS1saWJyYXJ5L3NyYy9zZXJ2aWNlbGliL3JlZGlzLnB5) | `94.1% <100.0%> (ø)` | | | [...tor\_v2/modules/dynamic\_sidecar/docker\_api/\_core.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869?src=pr&el=tree&filepath=services%2Fdirector-v2%2Fsrc%2Fsimcore_service_director_v2%2Fmodules%2Fdynamic_sidecar%2Fdocker_api%2F_core.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZGlyZWN0b3ItdjIvc3JjL3NpbWNvcmVfc2VydmljZV9kaXJlY3Rvcl92Mi9tb2R1bGVzL2R5bmFtaWNfc2lkZWNhci9kb2NrZXJfYXBpL19jb3JlLnB5) | `94.5% <ø> (ø)` | | | [...server/src/osparc\_gateway\_server/backend/osparc.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869?src=pr&el=tree&filepath=services%2Fosparc-gateway-server%2Fsrc%2Fosparc_gateway_server%2Fbackend%2Fosparc.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvb3NwYXJjLWdhdGV3YXktc2VydmVyL3NyYy9vc3BhcmNfZ2F0ZXdheV9zZXJ2ZXIvYmFja2VuZC9vc3BhcmMucHk=) | `82.3% <100.0%> (ø)` | | | [...ver/src/simcore\_service\_webserver/login/storage.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869?src=pr&el=tree&filepath=services%2Fweb%2Fserver%2Fsrc%2Fsimcore_service_webserver%2Flogin%2Fstorage.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvd2ViL3NlcnZlci9zcmMvc2ltY29yZV9zZXJ2aWNlX3dlYnNlcnZlci9sb2dpbi9zdG9yYWdlLnB5) | `95.6% <ø> (ø)` | | | [...ore\_service\_webserver/meta\_modeling/\_iterations.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869?src=pr&el=tree&filepath=services%2Fweb%2Fserver%2Fsrc%2Fsimcore_service_webserver%2Fmeta_modeling%2F_iterations.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvd2ViL3NlcnZlci9zcmMvc2ltY29yZV9zZXJ2aWNlX3dlYnNlcnZlci9tZXRhX21vZGVsaW5nL19pdGVyYXRpb25zLnB5) | `88.0% <100.0%> (ø)` | | | [...ore\_service\_webserver/resource\_manager/registry.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869?src=pr&el=tree&filepath=services%2Fweb%2Fserver%2Fsrc%2Fsimcore_service_webserver%2Fresource_manager%2Fregistry.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvd2ViL3NlcnZlci9zcmMvc2ltY29yZV9zZXJ2aWNlX3dlYnNlcnZlci9yZXNvdXJjZV9tYW5hZ2VyL3JlZ2lzdHJ5LnB5) | `98.7% <100.0%> (ø)` | | | [...server/src/simcore\_service\_webserver/groups/\_db.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869?src=pr&el=tree&filepath=services%2Fweb%2Fserver%2Fsrc%2Fsimcore_service_webserver%2Fgroups%2F_db.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvd2ViL3NlcnZlci9zcmMvc2ltY29yZV9zZXJ2aWNlX3dlYnNlcnZlci9ncm91cHMvX2RiLnB5) | `95.1% <0.0%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | | ... and [1333 files with indirect coverage changes](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5869/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)
sanderegg commented 1 month ago

thx. Do not forget to add the report in the description

@pcrespov like I said the report shows that nothing changed.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud